[systemd-devel] [PATCH] shared/install: don't report 'static' when unit contains only Also=

[Zbigniew Jędrzejewski-Szmek]

On Fri, Nov 07, 2014 at 03:25:11PM +0100, Jan Synacek wrote:
> Zbigniew Jędrzejewski-Szmek <zbyszek at in.waw.pl> writes:
> > On Fri, Nov 07, 2014 at 01:06:41PM +0100, Lennart Poettering wrote:
> >> On Fri, 07.11.14 09:49, Jan Synacek (jsynacek at redhat.com) wrote:
> >> 
> >> > Lennart Poettering <lennart at poettering.net> writes:
> >> > > On Thu, 06.11.14 10:49, Jan Synacek (jsynacek at redhat.com) wrote:
> >> > >
> >> > >> I think that this patch might be a bit ineffective, as it calls
> >> > >> unit_file_load() again just to get an InstallContext. I wasn't sure
> >> > >> how to get Also= targets in any other way.
> >> > >> 
> >> > >> If such change makes sense, this patch should probably be considered a
> >> > >> preview rather than something to be committed right away.
> >> > >
> >> > > Hmm, wouldn't it be nicer to introduce a new UnitFileState enum value
> >> > > for this?
> >> > >
> >> > > Maybe UNIT_FILE_ALSO or so? 
> >> > >
> >> > > I am not sure I like the idea of implicitly following the Also= setting here, due
> >> > > to the awkwarndess if multiple units are listed and how to map exotic
> >> > > states of that other unit back to ours...
> >> > >
> >> > > Would that make sense?
> >> > >
> >> > > Lennart
> >> > 
> >> > Yes, that makes sense. What should a string representation of
> >> > UNIT_FILE_ALSO be? I don't think that reporting 'also' would feel
> >> > right.
> > Maybe I'm missing something, but wouldn't be enough to report is as
> > 'enabled'?
> 
> AFAIK, it can also be disabled... Take systemd-journal-gatewayd.service
> as an example. It doesn't have anything but
> "Also=systemd-journal-gatewayd.socket" in the Install section. If you
> disable the socket, you would then return "enabled", which would be
> wrong.

Shit, sorry, I was thinking about about Alias=. Please disregard
my previous mail, I need to reread the thread while not trying to
do something else at the same time.

Zbyszek