[systemd-devel] [k]dbus: api, match replace and test extending

[Rui Miguel Silva]

Hi,

I have some questions regarding kdbus/dbus, maybe some could assist:

1\ api: when it is exported explicity bloom as filter implementation dont
you think that:
     - exporting through api an internal implementation, maybe it is not
       a good idea
     - technical debt, if in the future the filter mechanism is change by
       other than bloom.
so bloom maybe just be replaced with only generic filter could make more
sense?
 
2\ match_replace: it is not clear to me from the docs what should be the
behaviour when using the KDBUS_MATCH_REPLACE flag and the match with the
given cookie does not exist. In the implementation it is obvious that it
will add as a new match. but it is a feature or bug?
 
3\ testing: it is of any interess to provide more test code and cases at
kdbus level? or do not want to increase the testing scenario?

Cheers,
    Rui