[systemd-devel] [systemd-commits] src/cryptsetup

[Quentin Lefebvre]

Le 24/11/2014 19:01, Zbigniew Jędrzejewski-Szmek a écrit :
> On Mon, Nov 24, 2014 at 06:44:25PM +0100, Quentin Lefebvre wrote:
>> Hi,
>>
>> I tested your patch and actually it doesn't solve the bug.
>> For example, if "hash=sha512" is provided in /etc/crypttab, the
>> first >                           if (!streq(arg_hash, "plain"))
>> is true, and the
>>> +                } else if (!key_file)
>> is not reached.
> This is be design. My patch is quite different from your patch,
> which I tried to make clear in the description.
>
> If you specify hash=sha512, then you get hash=sha512.

Yes, and this is the problem.
cryptsetup ignores the hash, so that we should obtain hash=NULL for it 
to work.