[systemd-devel] [PATCH] localed: forward xkbcommon errors

[Lennart Poettering]

On Tue, 25.11.14 10:01, David Herrmann (dh.herrmann at gmail.com) wrote:

> I explicitly ignore errors from verify_xkb_rmlvo() and proceed.
> libxkbcommon is still not 100% compatible to libxkb (and doesn't
> intend to be that, I guess). As we write X11 configs here, I just
> continue with a warning.
> 
> If you call bus_error_setfv(), then sd-bus will return a method-error
> to the caller. However, you also send a method-return in
> method_set_x11_keyboard(). You thus end up with 2 calls.
> 
> I'm not sure how to solve this. Furthermore, libxkbcommon can print a
> lot of informational warnings, and we shouldn't use just the last one.
> One idea would be to copy the same logic into localectl. You could
> also specify XKB_LOG_LEVEL and XKB_LOG_VERBOSITY as environment to get
> more information there.
> Yes, this would mean compiling the keymap twice, but it's for the sake
> of debugging output so I think it's fine.

What precisely are the error messages libxkbcommon prints? Are they
really material to pass to the client? I mean, are they really about
some invalid data the client passed or just about something broken in
the way the system is set up? If it's the latter than I figure we
should return just a simple error to the client, and pass the full
logs to the logging stream...

Lennart

-- 
Lennart Poettering, Red Hat