[systemd-devel] [PATCH v2] journalctl: add --utc option

Jan Synacek jsynacek at redhat.com
Thu Oct 2 06:19:19 PDT 2014


Lennart Poettering <lennart at poettering.net> writes:
> On Thu, 02.10.14 14:39, Jan Synacek (jsynacek at redhat.com) wrote:
>
>> Introduce option to display time in UTC.
>
> Thanks!
>
> Applied!

Thanks! I just realized that the patch was incomplete. There are at
least two different places that need to be patched - format_timestamp()
and format_timestamp_us() in src/shared/time-util.c. I'm not sure about
the rest (grepping localtime_r reveals some more uses). I would extend
the API of those calls by one boolean saying if they should use UTC or
not, however that would break API. Would that be OK? Or do you suggest
anything else?

Cheers,
-- 
Jan Synacek
Software Engineer, Red Hat


More information about the systemd-devel mailing list