[systemd-devel] [PATCH] socket-proxyd: Unchecked return value from library

[Susant Sahani]

On 10/03/2014 12:21 AM, Lennart Poettering wrote:
> On Fri, 19.09.14 13:27, Susant Sahani (susant at redhat.com) wrote:
>
>> CID 1237543 (#1 of 1): Unchecked return value from library
>> (CHECKED_RETURN)
>> ---
>>   src/socket-proxy/socket-proxyd.c | 6 +++++-
>>   1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/src/socket-proxy/socket-proxyd.c b/src/socket-proxy/socket-proxyd.c
>> index ff2b24f..7b0714d 100644
>> --- a/src/socket-proxy/socket-proxyd.c
>> +++ b/src/socket-proxy/socket-proxyd.c
>> @@ -125,7 +125,11 @@ static int connection_create_pipes(Connection *c, int buffer[2], size_t *sz) {
>>                   return -errno;
>>           }
>>
>> -        fcntl(buffer[0], F_SETPIPE_SZ, BUFFER_SIZE);
>> +        r = fcntl(buffer[0], F_SETPIPE_SZ, BUFFER_SIZE);
>> +        if (r < 0) {
>> +                log_error("Failed to set pipe buffer size: %m");
>> +                return -errno;
>> +        }
>
> If this is about making coverity shut up: doesn't coverity undestand a
> syntax like the following?
>
> (void) fcntl(buffer[0], F_SETPIPE_SZ, BUFFER_SIZE);
>
> I.e. by explicitly casting the result of fcntl into void, coverity
> should really understand that we don't really care about the result.

Sorry for the late reply. Casting with void indeed works. Tested with 
splint.
Thanks for the tip.
>
> Would be happy to take a patch for that (if coverity groks this...)

Re-sending.

>
> Lennart
>


Susant