[systemd-devel] [PATCH] socket-proxyd: Unchecked return value from library

[Lennart Poettering]

On Fri, 10.10.14 05:57, Zbigniew Jędrzejewski-Szmek (zbyszek at in.waw.pl) wrote:

> On Thu, Oct 09, 2014 at 07:01:11PM +0530, Susant Sahani wrote:
> > CID 1237543 (#1 of 1): Unchecked return value from library
> > (CHECKED_RETURN)
> > ---
> >  src/socket-proxy/socket-proxyd.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/src/socket-proxy/socket-proxyd.c b/src/socket-proxy/socket-proxyd.c
> > index ff2b24f..3041903 100644
> > --- a/src/socket-proxy/socket-proxyd.c
> > +++ b/src/socket-proxy/socket-proxyd.c
> > @@ -125,7 +125,7 @@ static int connection_create_pipes(Connection *c, int buffer[2], size_t *sz) {
> >                  return -errno;
> >          }
> >  
> > -        fcntl(buffer[0], F_SETPIPE_SZ, BUFFER_SIZE);
> > +        (void) fcntl(buffer[0], F_SETPIPE_SZ, BUFFER_SIZE);
> >  
> >          r = fcntl(buffer[0], F_GETPIPE_SZ);
> >          if (r < 0) {
> For the sake of ML archives...
> 
> this was pushed by David.

So, according to the archives David actually did post a message where
he said he merged it:

http://lists.freedesktop.org/archives/systemd-devel/2014-October/023822.html

There appears to be something really wrong with mail delivery on fdo
currently, a couple of messages never got delivered to me, and I
checked with Kay and Daniel and they didn't get them either, thoug
they show up in the archives.

Usually I pinged Tollef about things like this, but I am not entirely
sure who to ping these days...

Lennart

-- 
Lennart Poettering, Red Hat