[systemd-devel] [PATCH] systemctl: add edit verb

[Ronny Chevalier]

2014-10-13 13:40 GMT+02:00 David Herrmann <dh.herrmann at gmail.com>:
> Hi
Hi,

>
> On Sat, Oct 11, 2014 at 8:17 PM, Daniel Buch <boogiewasthere at gmail.com> wrote:
>> Nice, I was in the process of implementing this. Looks good to me. But I
>> think it would be better to use "vi" instead of "vim" if no &editor is set.
>> Vim is not installed on every system as default but vi is most likely.
>
> I'd prefer doing nothing. "vi" has quite different behavior than
> "vim", especially in Ex mode. And for people uncomfortable with 'vi'
> it's even worth. And everyone should have set EDITOR anyway..
Yes, the first version that I made just shown an error saying that you
should set SYSTEMD_EDITOR or EDITOR, but
the RFE suggested using vim, and since no one was against it, I
thought this was common to use vi/vim when EDITOR is not set.

And, even as a vim user, I agree that for many people vi/vim is really
not a good choice.

I will resend the patch with the modification.

Thanks !

>
> Thanks
> David