[systemd-devel] [PATCHv2] logind: Support logind.conf.d directories in the usual search paths

[Lennart Poettering]

On Fri, 17.10.14 06:29, Josh Triplett (josh at joshtriplett.org) wrote:

> This makes it possible to drop in logind configuration snippets from a
> package or other configuration management mechanism.
> 
> Introduce a new helper, conf_parse_many, to parse configuration files in
> a search path.
> 
> systemd now installs /usr/lib/systemd/logind.conf.d/50-default.conf
> rather than /etc/systemd/logind.conf .  Distributions should migrate
> existing modified versions of /etc/systemd/logind.conf to
> /etc/systemd/logind.conf.d/50-default.conf .
> 
> Move the logind.conf manpage to logind.conf.d, update it to document the
> search paths, and update all references to it.

Humm....

I'd really prefer if we'd keep things in logind.conf and just provide
the option of using logind.conf.d. This would be similar to unit
files, where the unit files are where the beef is and .d/ is just a
way to override/extend is. THe man page of logind.conf should
reference the ability that .d/ files are supported, but that should be
it for the documentation. We should really try to not to be too
surprising here for admins which tend to expect one configuration
file, not many.

Also, I'd really prefer if we could do the same for all configuration
files in /etc/systemd/*.conf, not just for logind.conf...

An additional idea might be to document in the main config files as a
comment that extensions may be placed in the .d/ subdirs, to make this
functionality more discoverable?

> For systemd, are "git format-patch -M" patches (with git-style renames
> rather than whole-file deletion/insertions) acceptable for mailing list
> review?  That format makes renames much easier to review.

Sure!

Lennart

-- 
Lennart Poettering, Red Hat