[systemd-devel] [PATCH] bus-proxyd: improve compatibility with dbus-1

[Lennart Poettering]

On Tue, 14.10.14 19:40, Daniel Mack (daniel at zonque.org) wrote:

> On 10/13/2014 03:29 PM, Lukasz Skalski wrote:
> > 'GetConnectionUnixProcessID', 'GetConnectionUnixUser' and
> > 'GetConnectionSELinuxSecurityContext' methods should return
> > 'NameHasNoOwner' error (if chosen name is not available on bus)
> > with more detailed description - like dbus-1:
> > 
> > Could not get PID of name 'org.freedesktop.test': no such name.
> > Could not get UID of name 'org.freedesktop.test': no such name.
> > Could not get security context of name 'org.freedesktop.test': no such name.
> > 
> > Otherwise we have only laconic message without proper dbus error:
> > 
> > Error System.Error.ENXIO: No such device or address
> 
> Looks good to me.
> 
> Applied, thanks!

We already do the more friendly handling of the error message in
get_creds_by_name(), no need to duplicate that.

I have now reverted this patch and applied a different one that simply
passes the errors returned by get_creds_by_name() back to the client.

Lennart

-- 
Lennart Poettering, Red Hat