[systemd-devel] [PATCH 2/3] mac: rename apis with mac_{selinux/smack}_ prefix

[Lennart Poettering]

On Wed, 22.10.14 23:12, Lennart Poettering (lennart at poettering.net) wrote:

> On Thu, 16.10.14 16:59, WaLyong Cho (walyong.cho at samsung.com) wrote:
> 
> > -                if (smack_label_ip_in_fd(fd, s->smack_ip_in) < 0)
> > -                        log_error_unit(UNIT(s)->id, "smack_label_ip_in_fd: %m");
> > +                if (mac_smack_ip_in_fd(fd, s->smack_ip_in) < 0)
> > +                        log_error_unit(UNIT(s)->id,
> > -                        "mac_smack_ip_in_fd: %m");
> 
> I think this call should still contern a verb of some kind, do
> indicate what it does. mac_smack_label_ip_in_fd() or even
> mac_smack_relabel_ip_in_fd() or so?

Or maybe even mac_smack_fix_ip_in_fd()?

Lennart

-- 
Lennart Poettering, Red Hat