[systemd-devel] [PATCH 2/2] mac: rename apis with mac_{selinux/smack}_ prefix

[WaLyong Cho]

On 10/24/2014 07:56 AM, Lennart Poettering wrote:
> On Thu, 23.10.14 17:23, WaLyong Cho (walyong.cho at gmail.com) wrote:
> 
> Heya!
> 
> I merged both patches now! Thanks!
> 
> After merging I reworked quite a bit more code to make the selinux
> and smack bits work more similar to each. I cannot test this
> though, as I don't run SMACK. I really hope I didn't break anything,
> could you test and verify?
> 
As I know, Tizen is most active test bed of SMACK. But I'm not sure they
are using most recent systemd version. In my case, I'm working for
mobile division and We are using systemd version 210 now. So, to test
this we have to upgrade systemd to newest version. That's not easy now.
But whenever will be. :) At that time, I will test that.

Thanks,

WaLyong

> It would be good if you could go through the various commits since I
> merged your patch. There were some changes that might be particularly
> relevant. Most specifically, I changed the code that applies the SMACK
> label to a path to use lsetxattr() instead of setxattr(). The code to
> remove a SMACK label was already use lremovexattr(), so I figured we
> should be symmetric here, and it appeared safer to me. AFAICS this
> changed didn't break anything, but again, I didn't test it.
> 
> Thanks,
> 
> Lennart
>