[systemd-devel] [PATCH v3] udev hwdb: Support shipping pre-compiled database in system images

Martin Pitt martin.pitt at ubuntu.com
Fri Oct 24 08:52:39 PDT 2014


Hello all,

thanks Lennart for the detailled review! Took me a while to respond as
I'm on a company sprint this week. I think I addressed all your
points, plus fixing the unit condition. open_hwdb_bin() isn't the
prettiest thing in the world after the change of immediately
fopen()ing instead of just returning a path, but I don't have a good
idea to beautify it.

I tested ./udevadm hwdb --update with and without --vendor, and
./udevadm test-builtin hwdb in both cases.

Thanks,

Martin

-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-udev-hwdb-Support-shipping-pre-compiled-database-in-.patch
Type: text/x-diff
Size: 9066 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/systemd-devel/attachments/20141024/ecb6b0a4/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.freedesktop.org/archives/systemd-devel/attachments/20141024/ecb6b0a4/attachment.sig>


More information about the systemd-devel mailing list