[systemd-devel] [PATCH 3/4] shutdown: don't do final unmounting when inside the container and running without CAP_SYS_ADMIN

[Michal Sekletar]

On Wed, Oct 08, 2014 at 04:54:59PM +0200, Lennart Poettering wrote:
> On Wed, 08.10.14 16:49, Michal Sekletar (msekleta at redhat.com) wrote:
> 
> > > > > Hmm, I think we should just do "need_umount = !in_container", like we
> > > > > do for the other things like loopback detaching, dm detaching or
> > > > > swapoff. After all, if we run in a container we run in a mount
> > > > > namespace anyway, so unmounting things is done by the kernel
> > > > > implicitly if the namespace dies. At least in theory this means we can
> > > > > simply skip the unmounting in all containers, but I must admit that I
> > > > > am not entirely clear on this one, so this needs to be tested in the
> > > > > common container managers really, I figure...
> > > > 
> > > > Do you mind if I push just need_umount = !in_container then?
> > > 
> > > Well, yes.
> > > 
> > > I'd be thankful if you'd test this a bit first, so that this doesn't
> > > break anything. Testing nspawn and on bare-metal should be enough.
> > 
> > Works just fine on F21 KVM guest and in rawhide nspawn container.
> 
> THen please, go ahead, commit with a good commit msg explaining things,
> maybe even referencing this discussion.

Pushed with better explanation. Hope that commit message makes sense.

Michal

> 
> Thanks,
> 
> Lennart
> 
> -- 
> Lennart Poettering, Red Hat