[systemd-devel] [PATCH v6] udev hwdb: Support shipping pre-compiled database in system images

Martin Pitt martin.pitt at ubuntu.com
Tue Oct 28 04:18:47 PDT 2014


Hello Lennart,

Lennart Poettering [2014-10-28 11:31 +0100]:
> I'd prefer if you'd move the log message for the error into
> open_hwdb_bin() then, so that it is not the caller, but the callee
> which prints the error message in this case.

That would then mean to move most of udev_hwdb_new() into
open_hwdb_bin(). As the latter is only used once, I instead moved that
logic into udev_hwdb_new(), which also simplifies it somewhat. I also
added a new and clearer error message if hwdb.bin doesn't exist
anywhere.

Martin
-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-udev-hwdb-Support-shipping-pre-compiled-database-in-.patch
Type: text/x-diff
Size: 9491 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/systemd-devel/attachments/20141028/2167f197/attachment-0001.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.freedesktop.org/archives/systemd-devel/attachments/20141028/2167f197/attachment-0001.sig>


More information about the systemd-devel mailing list