[systemd-devel] [PATCH v3] Bootchart: use /proc/pid/mountinfo for root bdev

[Zbigniew Jędrzejewski-Szmek]

On Thu, Oct 30, 2014 at 05:45:53PM +0300, Timofey Titovets wrote:
> Good time of day, list.
> I have try to fix "Fixme" in svg.c:
> /* FIXME: this works only in the simple case */
> 
> By default function try to get only root=/dev/*
> I also attach patch. Thanks.
> 
> v2:
> 	Rewrited with use fstab_node_to_udev_node() and
> canonicalize_file_name() functions.
> v3:
> 	Rewrited for parsing /proc/self/mountinfo
> 
> Please test it, i'm can't test because i not have /proc/schedstat
> file (custom kernel)
> 
> I use " 0 " for searching root device its correct?
> For test:
> [$]: grep " 0 " /proc/self/mountinfo
No:

13 1 179:53 / / rw,noatime shared:1 - ext4 /dev/root rw,data=ordered

Why not check field 5 for "/"?

> I'm not use major:minor because on some setups it useless.
> As example, my system root:
> 50 0 0:28 /@ / rw,relatime shared:1 - btrfs /dev/sda3
> rw,compress=zlib,space_cache,autodefrag         ^
True, but you have the device name in there too   |

Zbyszek