[systemd-devel] [PATCH 8/8] timesyncd: wait before reconnecting to first server

Kay Sievers kay at vrfy.org
Tue Sep 2 06:32:35 PDT 2014


On Tue, Sep 2, 2014 at 3:17 PM, Miroslav Lichvar <mlichvar at redhat.com> wrote:
> On Tue, Sep 02, 2014 at 02:32:37PM +0200, Kay Sievers wrote:
>> On Tue, Sep 2, 2014 at 1:15 PM, Miroslav Lichvar <mlichvar at redhat.com> wrote:
>> >> There is also some code in src/timesync/timesyncd-manager.c +209:
>> >>   /* re-arm timer with increasing timeout,
>> >>   in case the packets never arrive back */
>> >>
>> >> which used to work but maybe broke with other changes.
>> >
>> > In the current code that doesn't work as the 10s reconnect timeout is
>> > always reached first.
>>
>> I see, I've removed it now.
>
> With the other patch allowing missed replies included it's now getting
> stuck as there is no timer to send the 2nd and 3rd request. Can you
> please add it back? Sorry I didn't make that clear before.

I see, I didn't realize that we use that now. Reverted.

Thanks,
Kay


More information about the systemd-devel mailing list