[systemd-devel] [PATCH v3] build: don't install busname units and target if kdbus support is disabled

[Michael Biebl]

2014-09-04 14:55 GMT+02:00 Michael Biebl <mbiebl at gmail.com>:
> 2014-09-04 14:31 GMT+02:00 Zbigniew Jędrzejewski-Szmek <zbyszek at in.waw.pl>:
>> On Thu, Sep 04, 2014 at 02:14:23PM +0200, Michael Biebl wrote:
>>> Hi,
>>>
>>> 2014-09-04 6:16 GMT+02:00 Zbigniew Jędrzejewski-Szmek <zbyszek at in.waw.pl>:
>>> > On Wed, Sep 03, 2014 at 11:51:58PM +0200, Michael Biebl wrote:
>>>
>>> >>  define add-wants
>>> >> -     [ -z "$$what" ] || ( \
>>> >> +     [ -z "$$what" ] || ! echo $$what | grep -q '[^[:space:]]' || ( \
>>> > Maybe we could use something simpler like
>>> >         [[ $what =~ ^[[:space:]]*$ ]] || ( \
>>>
>>> I didn't want to use a bash specific feature here, since /bin/sh is
>>> not guaranteed to point to bash.
>>> So I guess using grep is the safer choice and I'd like to keep that as is.
>> What about folding the first case into the grep pattern then?
>
> Since I didn't think this improved readability, I kept this as-is for now.

After reworking the patch as you suggested I realized, that bit is
actually not strictly necessary anymore,  as I use a different install
hook for busname units now.

So I dropped it again and updated the commit message accordingly.


-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-build-don-t-install-busname-units-and-target-if-kdbu.patch
Type: text/x-patch
Size: 5401 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/systemd-devel/attachments/20140904/01b7302b/attachment.bin>