[systemd-devel] [PATCH 1/2] shared/pty: remove unused pty_signal

[Emil Renner Berthing]

Hi,

On 15 September 2014 16:59, David Herrmann <dh.herrmann at gmail.com> wrote:
> Hi
>
> On Mon, Sep 15, 2014 at 3:29 PM, Emil Renner Berthing <systemd at esmil.dk> wrote:
>> ---
>>  src/shared/pty.c | 8 --------
>>  src/shared/pty.h | 1 -
>>  2 files changed, 9 deletions(-)
>>
>> diff --git a/src/shared/pty.c b/src/shared/pty.c
>> index 2863da4..a3332dd 100644
>> --- a/src/shared/pty.c
>> +++ b/src/shared/pty.c
>> @@ -541,14 +541,6 @@ int pty_write(Pty *pty, const void *buf, size_t size) {
>>          return 0;
>>  }
>>
>> -int pty_signal(Pty *pty, int sig) {
>> -        assert_return(pty, -EINVAL);
>> -        assert_return(pty_is_open(pty), -ENODEV);
>> -        assert_return(pty_is_parent(pty), -ENODEV);
>> -
>> -        return ioctl(pty->fd, TIOCSIG, sig) < 0 ? -errno : 0;
>> -}
>> -
>
> The main user of shared/pty.c (systemd-consoled) is still being worked
> on. The pty implementation was just one of the early works, so I'd
> prefer if we keep unused functions for now.

Ah, I see. Sorry for the noise then ;)

/Emil