[systemd-devel] [PATCH] Fix resource leak (coverity CID 1237760)
Daniel Mack
daniel at zonque.org
Thu Sep 18 01:14:53 PDT 2014
On 09/17/2014 11:10 PM, Cristian Rodríguez wrote:
> ---
> src/libsystemd/sd-bus/bus-kernel.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/src/libsystemd/sd-bus/bus-kernel.c b/src/libsystemd/sd-bus/bus-kernel.c
> index 505f335..b3cc996 100644
> --- a/src/libsystemd/sd-bus/bus-kernel.c
> +++ b/src/libsystemd/sd-bus/bus-kernel.c
> @@ -1446,9 +1446,11 @@ int bus_kernel_create_endpoint(const char *bus_name, const char *ep_name, char *
> }
>
> if (ep_path) {
> - asprintf(ep_path, "%s/%s", dirname(path), ep_name);
> - if (!*ep_path)
> + int r = asprintf(ep_path, "%s/%s", dirname(path), ep_name);
> + if (r == -1 || !*ep_path) {
> + safe_close(fd);
> return -ENOMEM;
> + }
> }
>
> return fd;
>
Applied, thanks!
More information about the systemd-devel
mailing list