[systemd-devel] [PATCH] udevd: SAS: use SAS addr + PHY id in by-path whenever possible.

[Tomas Henzl]

On 09/25/2014 05:07 PM, Kay Sievers wrote:
> On Thu, Sep 25, 2014 at 1:57 PM, Tomas Henzl <thenzl at redhat.com> wrote:
>> On 09/24/2014 05:03 PM, Kay Sievers wrote:
>>>>> Simple as: Don't add new features to systemd/udev, only fix bugs.
>> The by-path has been part of udev for a long time, the users of this
>> feature are from the same camp as the users of the,
>> 'enterprise storage'. Everyone has been happily using it,
>> until someone found out that the values shown are incorrect.
>> The patch posted here corrects the values so it can work as expected.
>> You probably were confused by something, but this is _not_ a new feature
>> it's a obvious bug fix.
>>
>> Please consider again inclusion of this patch.
> Sorry, we are better not changing the current, and possibly used link names.
> They are created that way since a long time and nobody knows who uses
> the current ones.
>
> Adding additional infrastructure to create more than one by-path link would
> be a new feature, which we will for various mentioned reasons not add to
> the current code, but which needs to happen in an external package,
> maintained/reviewed by someone with an enterprise-storage background
> and not live in the systemd code base.

I haven't noticed a single one technical reason why the by-path should be moved out
from udev and not fixed there when it's needed and most importantly how that move
would help the users of this feature.
The only point I can understand is that you don't like storage related code in udev
because you don't understand it and so you don't want to maintain it. 
I could try to explain that in case of any issues you may seek help in the scsi-misc list,
but well ok it's your decision.

This is I think by far not the last storage related code in udev, do you want to
remove the other parts too, like the by-uuid and the other by-* obvious candidates ?

Thanks,
Tomas

>
> I hope you understand the reasoning,
> Kay