[systemd-devel] [PATCH 3/5] udev: Update trackpoint rules to allow setting ibm trackpoint sensitivity

[Lennart Poettering]

On Thu, 02.04.15 11:48, Hans de Goede (hdegoede at redhat.com) wrote:

> +# Same as below but also sets the TPPS/2 IBM TrackPoint driver sensitivity
> +KERNELS=="input*", ATTR{device/name}=="TPPS/2 IBM TrackPoint", \
> +  IMPORT{builtin}="hwdb 'trackpoint:name:$attr{device/name}:$attr{[dmi/id]modalias}'", \
> +  RUN="/bin/sh -c 'echo -n $env{TRACKPOINT_SENSITIVTY} > /sys$env{DEVPATH}/../../../sensitivity'", \
> +  GOTO="trackpoint_end"

Invoking a shell for writing an attribute is certainly not OK. In
particular since ATTR{} can be used to write attributes.

Also, did you test this? THere's a pretty obvious typo in "TRACKPOINT_SENSITIVTY"...

Lennart

-- 
Lennart Poettering, Red Hat