[systemd-devel] [PATCH 1/5] udev-builtin-input_id: identify trackpoints and accelerometers

[Lennart Poettering]

On Thu, 02.04.15 12:21, Lennart Poettering (lennart at poettering.net) wrote:

> On Thu, 02.04.15 11:48, Hans de Goede (hdegoede at redhat.com) wrote:
> 
> > The kernel has been setting the INPUT_PROP_POINTING_STICK property bit
> > on trackpoints for a while now, and this is useful information to have
> > in various places, so make input_id aware of this and make it set
> > ID_INPUT_POINTING_STICK on trackpoints.
> > 
> > While adding support for querying properties, also add support for the
> > recently added INPUT_PROP_ACCELEROMETER property bit.
> > 
> > Signed-off-by: Hans de Goede <hdegoede at redhat.com>
> > ---
> >  src/udev/udev-builtin-input_id.c | 21 +++++++++++++++++++--
> >  1 file changed, 19 insertions(+), 2 deletions(-)
> > 
> > diff --git a/src/udev/udev-builtin-input_id.c b/src/udev/udev-builtin-input_id.c
> > index 46f1c53..5b1790c 100644
> > --- a/src/udev/udev-builtin-input_id.c
> > +++ b/src/udev/udev-builtin-input_id.c
> > @@ -33,6 +33,14 @@
> >  #include "udev.h"
> >  #include "util.h"
> >  
> > +#ifndef INPUT_PROP_POINTING_STICK
> > +#define INPUT_PROP_POINTING_STICK       0x05
> > +#endif
> > +
> > +#ifndef INPUT_PROP_ACCELEROMETER
> > +#define INPUT_PROP_ACCELEROMETER        0x06
> > +#endif
> 
> Are these definitions normally defined in input.h? If so, please add
> them to missing.h, where we try to centralize definitions of this kind.

Also, INPUT_PROP_POINTING_STICK is already introduced by Peter
Hutterer's most recent patch. He adds it to missing.h, can you sync
the two patche sets up, please?

Lennart

-- 
Lennart Poettering, Red Hat