[systemd-devel] [PATCH 1/3] sd-rtnl: Always enable IFA_FLAGS

[Alexander Sverdlin]

Hi!

On 25/03/15 14:36, Patrik Flykt wrote:
> IFA_FLAGS is a discrete value and has no preprocessor #define defined for
> it. Fix this by always using the value.

Seems that fix was not a real fix:

  CC       src/libsystemd/sd-id128/libsystemd_internal_la-sd-id128.lo
src/libsystemd/sd-rtnl/rtnl-types.c:361:10: error: ‘IFA_FLAGS’ undeclared here (not in a function)
         [IFA_FLAGS]             = { .type = NLA_U32 },
          ^
src/libsystemd/sd-rtnl/rtnl-types.c:361:9: error: array index in initializer not of integer type
         [IFA_FLAGS]             = { .type = NLA_U32 },
         ^
src/libsystemd/sd-rtnl/rtnl-types.c:361:9: error: (near initialization for ‘rtnl_address_types’)
Makefile:15503: recipe for target 'src/libsystemd/sd-rtnl/libsystemd_internal_la-rtnl-types.lo' failed
make[3]: *** [src/libsystemd/sd-rtnl/libsystemd_internal_la-rtnl-types.lo] Error 1

> ---
>  src/libsystemd/sd-rtnl/rtnl-types.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/src/libsystemd/sd-rtnl/rtnl-types.c b/src/libsystemd/sd-rtnl/rtnl-types.c
> index bf7278f..5ae4790 100644
> --- a/src/libsystemd/sd-rtnl/rtnl-types.c
> +++ b/src/libsystemd/sd-rtnl/rtnl-types.c
> @@ -358,9 +358,7 @@ static const NLType rtnl_address_types[IFA_MAX + 1] = {
>          [IFA_ANYCAST],
>          [IFA_MULTICAST],
>  */
> -#ifdef IFA_FLAGS
>          [IFA_FLAGS]             = { .type = NLA_U32 },
> -#endif
>  };
>  
>  static const NLTypeSystem rtnl_address_type_system = {
> 

Alex.