[systemd-devel] [PATCH] udev: input_id: tag accelerometers as ID_INPUT_ACCELEROMETER

[David Herrmann]

Hi

On Tue, Apr 7, 2015 at 3:47 AM, Peter Hutterer <peter.hutterer at who-t.net> wrote:
> On Sat, Apr 04, 2015 at 02:07:27PM +0200, David Herrmann wrote:
>> Hi
>>
>> On Fri, Apr 3, 2015 at 8:55 PM, Hans de Goede <hdegoede at redhat.com> wrote:
>> [...]
>> >> I don't think we should return when we see INPUT_PROP_ACCEL. If a
>> >> keyboard embeds an accelerometer, we will miss it. I think I went too
>> >> deep in detail for Wacoms/tablets devices and it confused you. Those
>> >> don't need much processing in udev, we can mostly control everything
>> >> out the tree.
>> >
>> >
>> > Ok, I'll respin my patch to not have the return then.
>>
>> What's the plan? Use INPUT_PROP_ACCEL as "negative check" (necessary
>> negative condition) for touchpads and mice? And as fallback hint for
>> accelerometer if nothing else matched?
[...]
> If we know that the x/y axes are accelerometers we know the device isn't a
> touchpad, mouse, pointing stick or touchscreen.

The open question was whether this will remain true in the future. But
I guess this assumption is pretty solid and we just ought to fix
kernel drivers that feed multiple input streams into a single evdev
device.

So yeah, patch is fine with me. Thanks for pushing!
David