[systemd-devel] [PATCH v2 3/4] hwdb: Add entries for the trackpoint on 2 Thinkpads

[Peter Hutterer]

On Tue, Apr 07, 2015 at 11:37:09AM +0200, Hans de Goede wrote:
> Hi,
> 
> On 07-04-15 07:07, Peter Hutterer wrote:
> >On Fri, Apr 03, 2015 at 04:11:59PM +0200, Hans de Goede wrote:
> >>Lenovo has changed the sensitity of the trackpoint on the x240 / T440s / T540
> >
> >s/sensitity/sensitivity/
> >
> >>generation of Thinkpads, making them somewhat unsensitive by default, add a
> >
> >I think it's "insensitive", not unsensitive.
> >
> >>hwdb entry to tweak the sensitivity setting.
> >>
> >>The ThinkPad X200s is way way too slow by default and unless you push the
> >>trackpoint quite hard only sends delta events in the 1-2 range, tweak the
> >>sensitivity to make it send a wider range of deltas and apply a const accel
> >>factor to make it have a more reasonable speed by default.
> >>---
> >>  hwdb/70-pointingstick.hwdb | 14 ++++++++++++++
> >>  1 file changed, 14 insertions(+)
> >>
> >>diff --git a/hwdb/70-pointingstick.hwdb b/hwdb/70-pointingstick.hwdb
> >>index d92434e..ea53019 100644
> >>--- a/hwdb/70-pointingstick.hwdb
> >>+++ b/hwdb/70-pointingstick.hwdb
> >>@@ -68,3 +68,17 @@
> >>
> >>  #
> >>  # Sort by by brand, model
> >>+
> >>+#########################################
> >>+# Lenovo
> >>+#########################################
> >>+
> >>+# Lenovo Thinkpad X200s
> >>+pointingstick:name:TPPS/2 IBM TrackPoint:dmi:bvn*:bvr*:bd*:svnLENOVO:pn*:pvrThinkPadX200s:*
> >>+  POINTINGSTICK_SENSITIVITY=200
> >>+  POINTINGSTICK_CONST_ACCEL=1.5
> >>+
> >>+# Lenovo Thinkpad T440s
> >>+pointingstick:name:TPPS/2 IBM TrackPoint:dmi:bvn*:bvr*:bd*:svnLENOVO:pn*:pvrThinkPadT440s:*
> >
> >this only catches the T440s, shouldn't we add the 240 and 540 as well then?
> 
> Yes and probably also the x1 from the same generation, etc. The problems are:
> 
> 1) Do we want to enable this on all without even a smoke-test ?
> 2) We need to have the DMI strings for these to add entries (I'm pretty sure we've those in
> some old bugs / patches)
> 
> Tonight I should be able to loan an x240 for a few hours then I'll test to see if it indeed too
> is too insensitive by default (according to the interwebs it is) and add an entry for it too.

I'd say if the t440 and the x240 are both affected, the t540 will be too so we
can add this untested.

Cheers,
   Peter