[systemd-devel] [RFC 1/6] proxy-discoveryd: Basic core added

[Lennart Poettering]

On Fri, 10.04.15 15:17, Tomasz Bursztyka (tomasz.bursztyka at linux.intel.com) wrote:

>  have_efi=no
>  AC_ARG_ENABLE(efi, AS_HELP_STRING([--disable-efi], [disable EFI support]))
>  if test "x$enable_efi" != "xno"; then
> @@ -1560,6 +1570,7 @@ AC_MSG_RESULT([
>          localed:                 ${have_localed}
>          networkd:                ${have_networkd}
>          resolved:                ${have_resolved}
> +	proxy-discoveryd:        ${have_proxy_discoveryd}

weird indenting?

> +++ b/units/systemd-proxy-discoveryd.service.in
> @@ -0,0 +1,18 @@
> +# This file is part of systemd.
> +#
> +# systemd is free software; you can redistribute it and/or modify it
> +# under the terms of the GNU Lesser General Public License as published by
> +# the Free Software Foundation; either version 2.1 of the License, or
> +# (at your option) any later version.
> +
> +[Unit]
> +Description=Proxy service
> +DefaultDependencies=no

Hmm, should this really be an early-boot service? Can you explain?

> +Requires=dbus.socket
> +After=dbus.socket
> +Before=remote-fs.target

Which this dependency? 

> +[Service]
> +Restart=on-failure
> +ExecStart=@rootlibexecdir@/systemd-proxy-discoveryd
> +StandardOutput=null

Why this last line?

Lennart

-- 
Lennart Poettering, Red Hat