[systemd-devel] [PATCH 4/4] Add a new tmpfiles.d snippets to set the NOCOW the journal.

[Lennart Poettering]

On Sun, 12.04.15 20:19, Goffredo Baroncelli (kreijack at libero.it) wrote:

> >> After the work that I done to the tmpfiles, I have to agree with
> >> Zbyszek. Adding an option to the journal.conf file is the more
> >> reasonable thing to do.
> > 
> > You mean journald.conf I figure? That's not even read by the remoting
> > tools, so how is that a solution?
> 
> In my first attempt, I added a switch to the command line.

So we'd even have two new options where we'd know now that they would
go away? And one of them isn't even persistent?

This really sounds wrong. We should be frugal with adding new options,
and this case is extraordinarily weak I think...

> Even if I agree with you about the points above, I am not fully
> convinced about changing the NOCOW attribute via tmpfile snippet:
> it seems to me an overkill solution..
> 
> But I prefer the snippet solution to the old behavior (set the NOCOW attribute
> coded in systemd-journald).

If you rebase the patches, and fix the issues I pointed out I am happy
to merge patches that set the c bit on the dirs via tmpfiles, and prints
a warning when creating a new journal file on btrfs where the flag is
off...

Lennart

-- 
Lennart Poettering, Red Hat