[systemd-devel] [PATCH 6/6] hwdb: set the resoluton for a couple of bcm5974 touchpads

Peter Hutterer peter.hutterer at who-t.net
Sun Apr 12 14:52:14 PDT 2015


On Tue, Apr 07, 2015 at 12:08:00PM +0200, David Herrmann wrote:
> Hi
> 
> On Mon, Mar 23, 2015 at 2:30 AM, Peter Hutterer
> <peter.hutterer at who-t.net> wrote:
> > Verified for the 5,1 Macbook, the others are guesses based on the list of
> > supported devices of the moshi trackpad protector.
> > http://www.moshi.com/trackpad-protector-trackguard-macbook-pro#silver
> >
> > Resolution calculated based on the min/max settings set in the kernel driver,
> > divided by the physical size. This is probably slightly off, but still better
> > than no resolution at all.
> >
> > Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
> > ---
> >  hwdb/60-evdev.hwdb | 40 ++++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 40 insertions(+)
> >
> > diff --git a/hwdb/60-evdev.hwdb b/hwdb/60-evdev.hwdb
> > index 0d67f87..9a9018f 100644
> > --- a/hwdb/60-evdev.hwdb
> > +++ b/hwdb/60-evdev.hwdb
> > @@ -35,3 +35,43 @@
> >  # fields of the struct input_absinfo as listed in linux/input.h.
> >  # If a field is missing the field will be left as-is. Not all fields need to
> >  # be present. e.g. ::45 sets the resolution to 45 units/mm.
> > +
> > +# Macbook5,1 (unibody), aka wellspring3
> > +evdev:input:b0003v05ACp0236*
> > +evdev:input:b0003v05ACp0237*
> > +evdev:input:b0003v05ACp0238*
> > + EV_ABS_OVERRIDE_00=::92
> > + EV_ABS_OVERRIDE_01=::90
> > + EV_ABS_OVERRIDE_35=::92
> > + EV_ABS_OVERRIDE_36=::90
> 
> So the keyboard properties were prefixed by our fake subsystem
> 'KEYBOARD_', and the entry we change 'KEY_foobar'. Can we do the same
> for the ABS override? 'EVDEV_ABS_foo=bar'?
> I don't think 'override' should be in the name. The hwdb simply stores
> axis information, it's the hwdb-user (builtin-input_id) which decides
> to override device-values with the hwdb-values. The hwdb doesn't
> define the policy.
> 
> Anyway, patches 4+5+6 look good to me! If Kay doesn't have any ideas
> for a better prefix than 'EVDEV_', I think you can go ahead an push
> it.

for the archives: pushed, commits up to 3ebc2dc49837e38288e1

Cheers,
   Peter


More information about the systemd-devel mailing list