[systemd-devel] [RFC 3/6] proxy-discoveryd: Add PAC support through duktape js engine

[Zbigniew Jędrzejewski-Szmek]

On Mon, Apr 13, 2015 at 01:24:57PM +0300, Tomasz Bursztyka wrote:
> Hi Tom,
> 
> >>--- a/Makefile.am
> >>+++ b/Makefile.am
> >>@@ -5895,12 +5895,19 @@ rootlibexec_PROGRAMS += \
> >>         systemd-proxy-discoveryd
> >>
> >>  systemd_proxy_discoveryd_SOURCES = \
> >>+       src/proxy-discovery/duktape.h \
> >>+       src/proxy-discovery/duktape.c \
> >These files are not included in the patch, how do you intend to ship them?
> 
> I figured this could be included as a separate commit, when it will
> be time to commit proxy-discoveryd someday.
> Those 2 files represent more than 2 megabytes, so I did not want to
> flood the ml.
duktape should not be embedded in systemd. It's a separate project,
which gets updates and has a life of its own.

Preferably, duktape would be packaged by distributions and we would
use it like any other external library. If that is not possible, we'll
have to look for some other option, but only then. For example,
git submodule is still better than embedding of a snapshot.

Zbyszek