[systemd-devel] [PATCH v2] cryptsetup: Implement offset and skip options

Martin Pitt martin.pitt at ubuntu.com
Fri Apr 17 10:32:15 PDT 2015


Hello all,

Zbigniew Jędrzejewski-Szmek [2015-04-16 23:42 +0000]:
> Hm, I'd go even further and add a check:
> 
> if (arg_offset && arg_type != NULL && arg_type != CRYPT_PLAIN)
>       log_warning("offset= ignored with type %s", arg_type);
> if (arg_skip && arg_type != NULL && arg_type != CRYPT_PLAIN)
>       log_warning("skip= ignored with type %s", arg_type);
> 
> But patch looks fine without this too.

For the archives: Lennart reviewed that on the fd.o bug and pointed
out some other issues (adding to crypttab.5, and cleaner struct init).
This is in master now.

Martin
-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)


More information about the systemd-devel mailing list