[systemd-devel] [PATCH 1/3] rules: Enable runtime device power management on Intel HDA controllers

Kay Sievers kay at vrfy.org
Sat Apr 18 10:51:26 PDT 2015


On Sat, Apr 18, 2015 at 6:11 PM, Matthew Garrett <mjg59 at srcf.ucam.org> wrote:
> From: Matthew Garrett <mjg59 at coreos.com>
>
> PCI power management seems to work fine on Intel HDA controllers, so let's
> turn that on. We can expand this to other vendors based on user feedback.

> +ACTION=="add", SUBSYSTEM=="pci", ATTR{class}=="0x040300", ATTR{vendor}=="0x8086", ATTR{power/control}="auto"

It looks like an unconditional static assignment.


Why should udev carry this? We generally do not want to do things like
that. Udev can help if there is conditional policy or complex
cross-subsystem knowledge is needed, but this looks just like a job
for the kernel and not userspace.

Kay


More information about the systemd-devel mailing list