[systemd-devel] [PATCH v4 0/4] udev: Add builtin and hwdb files for setting pointingstick properties

[David Herrmann]

Hi

On Fri, Apr 17, 2015 at 4:48 PM, Hans de Goede <hdegoede at redhat.com> wrote:
> Hi All,
>
> Here is v4 of my pointstick set.
>
> Changes since v3:
> -Use the existing evdev matching rules
> -Make setting the sensitivity part of the evdev builtin (which is called
>  keyboard for historical reasons)
>
> Changes since v2:
> -Fix numerous spelling / gramatical errors in commit messages
> -Add a reference to the kernel sources for the ibm trackpoint sensitivity
>  setting
>
> Changes since v1:
> -Drop the patch to set ID_INPUT_TRACKPOINT, Peter already send almost the
>  same patch to set ID_INPUT_POINTINGSTICK
> -s/trackpoint/pointingstick/ unlike trackpoint pointingstick is a vendor
>  neutral name, and pointingstick is also what the prop bit is called in
>  linux/input.h Note that a few occurences where not replaced, as those refer
>  specifically to IBM/Lenovo trackpoints
> -Use ATTR{foo}= to assign sysfs attr value rather then spawning /bin/sh
> -Dropped S-o-b from the commit messages

Looks all good, apart from my comments on patch #2. Please push!

Thanks
David