[systemd-devel] [systemd-commits] man/systemd.netdev.xml src/libsystemd src/network

[Lennart Poettering]

On Tue, 21.04.15 01:30, Lennart Poettering (lennart at poettering.net) wrote:

> > +        if (b->arp_interval != 0) {
> > +                r = sd_rtnl_message_append_u32(m, IFLA_BOND_ARP_INTERVAL, b->arp_interval / USEC_PER_MSEC);
> > +                if (r < 0) {
> > +                        log_netdev_error(netdev,
> > +                                         "Could not append IFLA_BOND_ARP_INTERVAL attribute: %s",
> > +                                         strerror(-r));
> > +                        return r;
> > +                }
> > +        }
> 
> I'd really prefer if we wouldn't add new code using strerror().
> 
> Maybe it's time to introduce log_netdev_error_errno(), that is the
> combination of what log_error_errno() and log_netdev_error() do? We
> already have the anem for log_network_xyz()...

I added log_netdev_error_errno() now, and converted a good chunk of
the networkd code to use it. Would be great to get the rest converted
too!

Lennart

-- 
Lennart Poettering, Red Hat