[systemd-devel] [PATCH 1/3] journal: add int↔audit type name mapping

[Zbigniew Jędrzejewski-Szmek]

On Mon, Apr 20, 2015 at 04:39:41PM +0200, Lennart Poettering wrote:
> On Tue, 14.04.15 21:58, Zbigniew Jędrzejewski-Szmek (zbyszek at in.waw.pl) wrote:
> 
> >  
> > +src/journal/audit_type-list.txt:
> > +	$(AM_V_at)$(MKDIR_P) $(dir $@)
> > +	$(AM_V_GEN)$(CPP) $(CFLAGS) $(AM_CPPFLAGS) $(CPPFLAGS) -dM -include linux/audit.h - </dev/null | grep -vE 'AUDIT_(FIRST|LAST)_.*MSG' | $(SED) -r -n 's/^#define\s+AUDIT_(\w+)\s+([0-9]{4})\s*$$/\1\t\2/p' | sort -k2 >$@
> 
> We add some more in missing.h, so this should probably be added, too, here?
Added.
 
> > +#include "audit-type.h"
> > +
> > +static const struct audit_type_name *
> > +lookup_audit_type(register const char *str, register unsigned int
> > len);
> 
> Weird line break...
I think your mail client must have wrapped it. It is one line here.

> > +const char *audit_type_to_string(int type);
> 
> is this one actually implemented?
It is generated in Makefile.am.

Zbyszek