[systemd-devel] [PATCH 1/2] Don't use ALSA card id in ID_ID

[Adam Goode]

On Mon, Apr 20, 2015 at 3:25 PM, Adam Goode <agoode at google.com> wrote:

> On Mon, Apr 20, 2015 at 2:40 PM, Lennart Poettering <
> lennart at poettering.net> wrote:
>
>> On Mon, 20.04.15 20:39, Lennart Poettering (lennart at poettering.net)
>> wrote:
>>
>> > On Mon, 20.04.15 20:00, Lennart Poettering (lennart at poettering.net)
>> wrote:
>> >
>> > > On Fri, 10.04.15 22:27, Adam Goode (agoode at google.com) wrote:
>> > >
>> > > > The ALSA id sysattr is generated by the sound subsystem and is not
>> > > > a stable identifier. It is generated though some string manipulation
>> > > > then made unique if there is a conflict. This means that it is
>> > > > enumeration-dependent and shouldn't be used for ID_ID.
>> > > >
>> > > > If ID_ID is supposed to be system-unique, it is not already since
>> > > > for firewire it is generated from the guid and there are broken
>> > > > firewire devices that have duplicate guids across devices.
>> > >
>> > > Hmm, this patch pretty much reverts
>> > > ed1b2d9fc7d5c5bfe2a67b0b8ff9e5ea8694268e. Now I am not sure if that
>> > > commit from 6 years ago was a good idea, but we should have some
>> > > clarity about this.
>> > >
>> > > What is ID_ID actually supposed to be? Should it really be system
>> > > unique?
>> > >
>> > > I do have the suspicion this is something that better should be fixed
>> in
>> > > PA rather then in these udev rules, so I figure your patch might be a
>> > > good idea?
>> > >
>> > > Opinions?
>> > >
>> > > If we apply the patch somebody should at least post a bug report
>> > > against PA to be aware of this change.
>> >
>> > OK, after talking to some folks I think we should merge your
>> > patch. Any chance you can post a bug to PA though, reference this
>> > discussion, and then include the bug report in the commit message and
>> > resend the patch?
>>
>> Also, please mention in the commit msg that this is basically a revert
>> of ed1b2d9fc7d5c5bfe2a67b0b8ff9e5ea8694268e.
>>
>>
> Thanks, happy to do this. Look for it soon.
>
>
>
I filed a bug and sent the new patches.

https://bugs.freedesktop.org/show_bug.cgi?id=90129


Thanks,

Adam
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/systemd-devel/attachments/20150421/d880d026/attachment.html>