[systemd-devel] [PATCH] vconsole: rerun setup on console takeovers as well

[Lennart Poettering]

On Tue, 24.02.15 19:23, Jan Engelhardt (jengelh at inai.de) wrote:

Sorry for the late reply,

> When a system, which has an FB driver and fbcon loaded and active,
> then the font state gets lost on console takeovers, as for example
> issued by i915. Since fbcon remains loaded and active, the existing
> event handling (add/vtcon*) is not sufficient.

what's the precise effect of this? I mean, iirc we already might end
up calling s-v-s twice, since it is pulled in from a udev rule and
during normal boot. Does this mean it is regularly pulled in thrice
even?

Isn#t the right fix to make the kernel keep the font settings around
during the fb transition?

Can you elaborate a bit on this? Kinda missing the details before I
can merge this.

David, Kay, any idea about this?

> ---
> This goes on top of the other patchset I sent earlier.
>  "[PATCH 1/2] vconsole: match on vtcon events, not fbcon ones"
> 
>  src/vconsole/90-vconsole.rules.in | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/src/vconsole/90-vconsole.rules.in b/src/vconsole/90-vconsole.rules.in
> index 35b9ad5..e05ecbf 100644
> --- a/src/vconsole/90-vconsole.rules.in
> +++ b/src/vconsole/90-vconsole.rules.in
> @@ -8,3 +8,7 @@
>  # Each vtcon keeps its own state of fonts.
>  #
>  ACTION=="add", SUBSYSTEM=="vtconsole", KERNEL=="vtcon*", RUN+="@rootlibexecdir@/systemd-vconsole-setup"
> +
> +# Handle the case of console takeover where the fb device is replaced.
> +#
> +ACTION=="add", SUBSYSTEM=="graphics", KERNEL=="fb[0-9]*", RUN+="@rootlibexecdir@/systemd-vconsole-setup"
> -- 
> 2.1.4
> 
> _______________________________________________
> systemd-devel mailing list
> systemd-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/systemd-devel


Lennart

-- 
Lennart Poettering, Red Hat