[systemd-devel] [PATCH] build-sys: Lookup for the location of agetty

[Lennart Poettering]

On Mon, 16.02.15 12:42, Cristian Rodríguez (crrodriguez at opensuse.org) wrote:

> May be in /sbin or /usr/sbin

Hmm, who would place the getty in /usr/sbin and not link this up  in
/sbin?

Anyway, I also see no reason not to merge something like this, but:

> --- a/units/getty at .service.m4
> +++ b/units/getty at .service.m4
> @@ -27,7 +27,7 @@ ConditionPathExists=/dev/tty0
>  
>  [Service]
>  # the VT is cleared by TTYVTDisallocate
> -ExecStart=-/sbin/agetty --noclear %I $TERM
> +ExecStart=- at AGETTY@ --noclear %I $TERM

This cannot work. We don't pass this one through @@ expansion, only
through m4. The @AGETTY@ will still be @AGETTY@ after the generation
of the final service file.

if you want this to work, then you need to also pass this through @@
expansion, and then through m4, like this is done for the other
files. Or in other words: this would need to become a .m4.in file, not
just a .in file.

>  Type=idle
>  Restart=always
>  RestartSec=0
> diff --git a/units/serial-getty at .service.m4 b/units/serial-getty at .service.m4
> index 4522d0d..bafbbb2 100644
> --- a/units/serial-getty at .service.m4
> +++ b/units/serial-getty at .service.m4

Same for this one.

Lennart

-- 
Lennart Poettering, Red Hat