[systemd-devel] [PATCHv2] core: do not spawn jobs or touch other units during coldplugging

[Lennart Poettering]

On Fri, 24.04.15 16:04, Lennart Poettering (lennart at poettering.net) wrote:

> On Fri, 24.04.15 15:52, Lennart Poettering (lennart at poettering.net) wrote:
> 
> > before we coldplug a unit, we should coldplug all units it might
> > trigger, which are those with a listed UNIT_TRIGGERS dependency, as
> > well as all those that retroactively_start_dependencies() and
> > retroactively_stop_dependencies() operates on. Of course, we should
> > also avoid running in loops here, but that should be easy by keeping a
> > per-unit coldplug boolean around.
> 
> Actually, it really is about the UNIT_TRIGGERS dependencies only,
> since we don't do the retroactive deps stuff at all when we are
> coldplugging, it's conditionalized in m->n_reloading <= 0.

I have implemented this now in git:

http://cgit.freedesktop.org/systemd/systemd/commit/?id=f78f265f405a61387c6c12a879ac0d6b6dc958db

Ivan, any chance you can check if this fixes your issue? (Not sure it
does, because I must admit I am not entirely sure I really understood
it fully...)

Lennart

-- 
Lennart Poettering, Red Hat