[systemd-devel] [systemd-commits] TODO

[Zbigniew Jędrzejewski-Szmek]

On Wed, Apr 29, 2015 at 11:51:18AM +0200, Martin Pitt wrote:
> Hello all,
> 
> Lennart Poettering [2015-04-28 17:48 +0200]:
> > Hmm, so, anyone found out anything useful about this? None of the
> > links above has anything useful really. I have never seen this issue
> > myself, so I kinda am relying on input from those who experiencing
> > this.
> > 
> > Is this still an issue with current, unpatched git (which has fsckd
> > removed among other changes).
> 
> Good news! I restarted my Reboot Loop Smoke Test Of Doom, and git
> master indeed seems fine. So a git bisect run [1] and a few hours
> later tells me that apparently
> http://cgit.freedesktop.org/systemd/systemd/commit/?id=64144440 fixes
> this for good. Thanks to Zbigniew and Coverity! :-)
As I wrote in the commit message, I didn't see anything wrong in the
original code. But if you say it helps... I don't mind.

> Thus it seems the bug was really introduced in
> http://cgit.freedesktop.org/systemd/systemd/commit/?id=a354329f72 and
> the reverted commit
> http://cgit.freedesktop.org/systemd/systemd/commit/?id=13790add4bf64
> merely exposed the bug as journald was (one of the) first user of fd
> storage.
> 
> Commit 64144440 applies cleanly on top of v219-stable, so I replaced
> our reverted patch with a backport of that fix, and successfully
> re-tested a package with that. Can we get this into v219-stable?
I'll push to -stable.

> (FTR: This bug was reported before fsckd, so that had nothing to do
> with it)
> 
> Thanks,
> 
> Martin (who is happy that this excruciating bug finally seems fixed)
> 
> [1] Every time I use this a small kitten comes back to life!
> 
> -- 
> Martin Pitt                        | http://www.piware.de
> Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)
> _______________________________________________
> systemd-devel mailing list
> systemd-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/systemd-devel