[systemd-devel] [PATCH] timesyncd: Make saving clock to disk on NTP fix optional

[Colin Guthrie]

Zbigniew Jędrzejewski-Szmek wrote on 01/02/15 15:58:
> On Sun, Feb 01, 2015 at 10:56:39AM -0300, Cristian Rodríguez wrote:
>> El 01/02/2015 06:36, "Kay Sievers" <kay at vrfy.org> escribió:
>>>
>>> On Feb 1, 2015 5:34 AM, "Zbigniew Jędrzejewski-Szmek" <zbyszek at in.waw.pl>
>> wrote:
>>>>
>>>> Kay, Lennart,
>>>> comments?
>>>
>>> Sounds like overkill to me for such an exotic requirement. Just link the
>> file to /dev/null and be done?
>>
>> Yeah, I do not see the point on providing this option,  only the file
>> timestamp is updated. That causes very little io.
>> Symlink to null is the best solution IMHO.
> 
> OK, I didn't think about that.
> 
> Philipp, I'll close the bug then, since the symlink thing works just as well.

In the commit message it says that it still touches the file on shutdown
which gives the cross-boot monotonic features between boots but
sacrifices it for unexpected reboots.

Surely the symlink to /dev/null only solves the disabling of the feature
fully, and doesn't have the option to still get the benefits on
controlled circumstances.

Not suggesting that this makes the patch worthwhile, but just
highlighting that the "just as well" comment isn't quite correct in the
context of the patch (not read the bug tho' so it may just be asking for
a "completely disable it" option :)

Col


-- 

Colin Guthrie
gmane(at)colin.guthr.ie
http://colin.guthr.ie/

Day Job:
  Tribalogic Limited http://www.tribalogic.net/
Open Source:
  Mageia Contributor http://www.mageia.org/
  PulseAudio Hacker http://www.pulseaudio.org/
  Trac Hacker http://trac.edgewall.org/