[systemd-devel] [PATCH 04/12] Add some plymouth functionality to connect and send, messages

[Didier Roche]

Le 31/01/2015 01:44, Zbigniew Jędrzejewski-Szmek a écrit :
> On Thu, Jan 29, 2015 at 06:42:42PM +0100, Didier Roche wrote:
>> Le 28/01/2015 15:44, Zbigniew Jędrzejewski-Szmek a écrit :
>>> On Wed, Jan 28, 2015 at 02:22:04PM +0100, Didier Roche wrote:
>>>>   bool plymouth_running(void) {
>>>>           return access("/run/plymouth/pid", F_OK) >= 0;
>>>>   }
>>>> +
>>>> +#ifdef HAVE_PLYMOUTH
>>>> +bool plymouth_connect(void) {
>>> Is there a particular reason why this cannot return a normal int code?
>> No reason, I changed to 0 for connected, -1 for can't connect.
> No, please return a real return code (-ENOMEM on the allocation failure
> in this case). -1 is EPERM.

Done, (even if I think that particular function is going to change with 
the libplymouth dep removal.
>
> Zbyszek