[systemd-devel] [PATCH] Ensure that systemd is the init called after using bootchart

[Martin Pitt]

Ça va Sebastien,

Sebastien Bacher [2015-02-02 16:14 +0100]:
> When booting with systemd-bootchart, default to call the systemd binary
> rather than the init binary on disk, which might be another init system.
> Collecting data doesn't work out of systemd.

I'm not a native speaker either, but "out of systemd" sounds strange.
"only works with booting systemd."?

> -#define DEFAULT_INIT "/sbin/init"
> +#ifdef HAVE_SPLIT_USR
> +#define DEFAULT_INIT "/lib/systemd/systemd"
> +#else
> +#define DEFAULT_INIT "/usr/lib/systemd/systemd"
> +#endif

Since ./configure allows you to specify paths independent from
--enable-split-usr, IMHO it is more robust to do

  #define DEFAULT_INIT ROOTLIBDIR "/systemd/systemd"

The idea sounds sane in general, though. Specifying
init=/usr/lib/systemd/systemd-bootchart is pretty explicit about which
init system one wants.

Merci,

Martin
-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)