[systemd-devel] [systemd-commits] 8 commits - man/custom-html.xsl man/systemd-nspawn.xml src/core src/fsck src/journal src/journal-remote src/libsystemd src/libsystemd-terminal src/shared src/timedate src/tmpfiles units/systemd-backlight at .service.in units/systemd-journal-catalog-update.service.in units/systemd-journal-flush.service.in

[Lennart Poettering]

On Mon, 02.02.15 23:25, Zbigniew Jędrzejewski-Szmek (zbyszek at in.waw.pl) wrote:

> On Mon, Feb 02, 2015 at 09:36:15PM +0100, Lennart Poettering wrote:
> > On Mon, 02.02.15 21:21, Lennart Poettering (lennart at poettering.net) wrote:
> > 
> > I now fixed all but the DECIMAL_STR_MAX() + 1 issue now...
> > 
> > Was too lazy for DECIMAL_STR_MAX() thing...
> Hm, I'm not sure if we want DECIMAL_STR_MAX to include the space for
> the null. Sometimes there's more than one decimal in a format.
> Also, even if there's just one, but not at the end, it somehow feels
> awkward to have the extra byte "allocated" in the middle of the string.

Yeah, I figure it would make sense to remove the +1 for the NUL byte
from the macro. If you want to fix this, go ahead, but of course this
would mean checking all current uses of that macro to see if it needs
an extra +1 then...

Lennart

-- 
Lennart Poettering, Red Hat