[systemd-devel] [PATCH] Propagate reload from RELOADING=1 notifications

Lennart Poettering lennart at poettering.net
Mon Feb 2 16:46:40 PST 2015


On Tue, 06.01.15 16:33, Zbigniew Jędrzejewski-Szmek (zbyszek at in.waw.pl) wrote:

> > Isn't that just bad behavior? Sending a RELOADING=1 notification after
> > a reload is initiated? I guess if both service_enter_reload() and
> > service_enter_reload_by_notify() are called it is justified to
> > propagate two reloads. Before testing it might be nice to know what we
> > want :-).
> 
> Hm. Looking at the code, sending periodic RELOADING=1 notifications
> can be used to sidestep the timeouts. This does not look OK, but maybe
> I'm misreading the code.

I think you are reading the code right. Not sure though whether that
should be considered a bug though... 

Lennart

-- 
Lennart Poettering, Red Hat


More information about the systemd-devel mailing list