[systemd-devel] [PATCH] Avoid reloading services when shutting down

[Lennart Poettering]

On Tue, 03.02.15 21:58, Michael Biebl (mbiebl at gmail.com) wrote:

> 2015-02-03 21:52 GMT+01:00 Lennart Poettering <lennart at poettering.net>:
> >
> > But note that this way you alter *all* queued jobs that way,
> > regardless if they are created with the assumptions of sysv behaviour
> > or if they were created in code that understands systemd's semantics,
> > and actually cares for the correct ordering..
> 
> The patch does not alter any ordering, it simply throws away
> reload/restart requests, which would be pointless anyway.

Well, OK, "cares for execution of the jobs", then.

> > I'd strongly recommend finding local solutions to the problems at hand
> > here, rather than changing behaviour for all other non-sysv code as
> > well...
> 
> Maybe this is an misunderstanding, but this issue is not sysv specific at all.

I don't see how this would apply to non-sysv code. I mean, code that
is written with systemd semantics in mind should be able to issue a
service reload during any time it wants to, if it keeps the ordering
issues in mind. For example, if I have a service that has
DefaultDependencies=no (and hence ordered against nothing at all by
default), and I want to issue systemctl reload on it, knowing that
this cannot really deadlock, since there are no deps that could cause
deadlocks, then i should be able to do so. With your patch you turn
these reloads into NOPs...

Lennart

-- 
Lennart Poettering, Red Hat