[systemd-devel] [PATCH] rules: Fix by-path of mmc RPMB partitions and don't blkid them

Martin Pitt martin.pitt at ubuntu.com
Thu Feb 12 10:52:47 PST 2015


Lennart Poettering [2015-02-12 18:50 +0100]:
> > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=090d25fe224c0
> 
> Looks simple enough. Though I wonder if [0-9] is the right match,
> shouldn't it also cover multiple numbers there?

Hm, yes. fnmatch() doesn't support a regexp-like "one or more digits";
it's less precise, but as the kernel doesn't generate arbitrary device
names but at most things like "mmcblk0p1", extending the glob to
mmcblk[0-9]*rpmb is actually safe.

Thanks,

Martin

-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-rules-Fix-by-path-of-mmc-RPMB-partitions-and-don-t-b.patch
Type: text/x-diff
Size: 2274 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/systemd-devel/attachments/20150212/10f67129/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.freedesktop.org/archives/systemd-devel/attachments/20150212/10f67129/attachment.sig>


More information about the systemd-devel mailing list