[systemd-devel] [PATCH] test: bump KDBUS_CONN_MAX_MSGS_PER_USER value

[Lukasz Skalski]

On 02/17/2015 12:20 PM, Djalal Harouni wrote:
> Hi Lukasz,
> 

Hi Djalal,

> On Tue, Feb 17, 2015 at 11:37:53AM +0100, Lukasz Skalski wrote:
>> diff --git a/test/test-message.c b/test/test-message.c
>> index 03ac71e..0cae942 100644
>> --- a/test/test-message.c
>> +++ b/test/test-message.c
>> @@ -28,7 +28,7 @@
>>   * maximum number of queued messages from the same indvidual user after the
>>   * the un-accounted value has been hit
>>   */
>> -#define KDBUS_CONN_MAX_MSGS_PER_USER		16
>> +#define KDBUS_CONN_MAX_MSGS_PER_USER		128
> Actually, the limit bump is just a temporary solution, to inspect or fix
> other bugs related to Gnome. David is working on this, I will let him
> decide if he wants to apply this patch or let it as it...
> 

Yes, I know that it is temporary solution, but at this moment, after
bumping KDBUS_CONN_MAX_MSGS_PER_USER value we have some new errors in
tests - for example in test-message.c:736 we get EXFULL errno
(queue.c:287 says that we can't take more than half of the remaining
space) instead of ENOBUFS. IMO we should align tests with latest changes.

> Thank you Lukasz!
> 
> 
>>  #define MAX_USER_TOTAL_MSGS  (KDBUS_CONN_MAX_MSGS_UNACCOUNTED + \
>>  				KDBUS_CONN_MAX_MSGS_PER_USER)
>> diff --git a/test/test-policy-ns.c b/test/test-policy-ns.c
>> index 3437012..3c8b78e 100644
>> --- a/test/test-policy-ns.c
>> +++ b/test/test-policy-ns.c
>> @@ -38,7 +38,7 @@
>>  #define MAX_CONN	64
>>  #define POLICY_NAME	"foo.test.policy-test"
>>  
>> -#define KDBUS_CONN_MAX_MSGS_PER_USER            16
>> +#define KDBUS_CONN_MAX_MSGS_PER_USER            128
>>  
>>  /**
>>   * Note: this test can be used to inspect policy_db->talk_access_hash
>> -- 
>> 1.9.3
>>
>> _______________________________________________
>> systemd-devel mailing list
>> systemd-devel at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/systemd-devel
> 

-- 
Lukasz Skalski
Samsung R&D Institute Poland
Samsung Electronics
l.skalski at samsung.com