[systemd-devel] [PATCH 8/9] Add man page and references to it.

[Didier Roche]

Le 14/02/2015 17:58, Zbigniew Jędrzejewski-Szmek a écrit :
> On Thu, Feb 05, 2015 at 06:11:24PM +0100, Didier Roche wrote:
Thanks for the suggestions, all applied!

>>
>> +
>> +    <para>The first time it connects to plymouth, a request
>> +    to grab Control+C keypresses is sent, as well as a text message.
>> +    When the cancel key is pressed, all running fscks are terminated.
>> +    It will also cancel any new connected fsck for the lifetime of
>> +    <filename>systemd-fsckd</filename>.</para>
> <para><command>systemd-fsckd</> will instruct plymouth to grab
> Control+C keypresses. When the key is pressed, running checks will be
> terminated. It will also cancel any newly connected fsck instances for
> the lifetime of <filename>systemd-fsckd</filename>.</para>
>
> This raises an intereseting question. IIUC, fsckd will exit on idle
> after 30s, losing the information that ^C was pressed. Shouldn't
> the exit-on-idle be raised to something bigger like 5 minutes, to
> make this less likely to happen?

Good point, 30s of idleness (and so keeping ^C status) sounded enough to 
me at boot time (the more likely this will occur), most of fsck will 
chain anyway (first, the root one, and then, the other disks). Do you 
think about some cases with some .mount unit that are activated 
afterwards but still while plymouth is shown, like some encrypted /home 
partitions before the display manager shows up (didn't include the 
change, happy to do it though)?


>> +
>> +    <para><filename>systemd-fsckd</filename> passes the
>> +    following messages to the theme via libplymouth:</para>
> Does it actually use libplymouth?

argh, sorry, didn't change it. Now done.
>
> +
> +  <refsect1>
> +    <title>See Also</title>
> +    <para>
> +      <citerefentry><refentrytitle>systemd</refentrytitle><manvolnum>1</manvolnum></citerefentry>,
> +      <citerefentry><refentrytitle>systemd-fsck</refentrytitle><manvolnum>8</manvolnum></citerefentry>,
> +      <citerefentry><refentrytitle>fsck</refentrytitle><manvolnum>8</manvolnum></citerefentry>,
> +      <citerefentry><refentrytitle>systemd-quotacheck.service</refentrytitle><manvolnum>8</manvolnum></citerefentry>,
> Please add something like project='man-pages' (needs to be checked) to citerefentry,
> so the links are correct in html version.
Seems to be project='man-pages' indeed. Done when referring to non 
systemd manpages (for the fsck* references) and same on 
man/systemd-fsck at .service.xml

Cheers,
Didier

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0008-Add-man-page-and-references-to-it.patch
Type: text/x-diff
Size: 14400 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/systemd-devel/attachments/20150217/cd245c5c/attachment.patch>