[systemd-devel] [PATCH 3/9] Connect to plymouth and support cancellation of in, progress fsck

[Didier Roche]

Le 18/02/2015 00:30, Zbigniew Jędrzejewski-Szmek a écrit :
> On Tue, Feb 17, 2015 at 05:26:05PM +0100, Didier Roche wrote:
>>>> +                r = send_message_plymouth_socket(m->plymouth_fd, plymouth_cancel_message, false);
>>>> +                if (r < 0)
>>>> +                        log_warning_errno(r, "Can't send cancel user message to plymouth: %m");
>>>> +        } else if (m->numdevices == 0) {
>>>> +                m->plymouth_cancel_sent = false;
>>>> +                r = send_message_plymouth_socket(m->plymouth_fd, "", false);
>>>> +                if (r < 0)
>>>> +                        log_warning_errno(r, "Can't clear cancel user message to plymouth: %m");
>>> Not *that* important, but those two log_warning_errnos are poorly worded.
>>> If I was a user, I'd be a bit worried if I saw that somebody tried to
>>> cancel me, even if they failed ;)
>> Ahah, good point! Slightly reworded.
>>>   Also "clear ... to".
>> isn't what I used above? "clear … to"
> Well, yes, but still this sentence doesn't make sense.

Changed to "Can't clear plymouth filesystem cancel message: %m"

Didier

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Connect-to-plymouth-and-support-cancellation-of-in-p.patch
Type: text/x-diff
Size: 15058 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/systemd-devel/attachments/20150218/fe183dfb/attachment.patch>